-
Notifications
You must be signed in to change notification settings - Fork 16.4k
Description
Preflight Checklist
- [x ] I have read the Contributing Guidelines for this project.
- [x ] I agree to follow the Code of Conduct that this project adheres to.
- [ x] I have searched the issue tracker for an issue that matches the one I want to file, without success.
Issue Details
- Electron Version:
Electron 10 and beyond (have tried 10.2.0, 10.3.2, 10.4.0 and 11.2.0) - Operating System:
- macOS 10.15.7
- Last Known Working Electron version:
Electron 8.5.1
Expected Behavior
Upon upgrading from electron 8 to electron 10, we started noticing drag issues in our frameless macOS electron app. In our app, we have a BrowserWindow with a sidebar of fixed width and then there are a few overlapping browserviews that start with the x coordinate being the width of the sidebar. We started seeing a drag region appear on the righthand side of the app, the same size as the x offset and this whole entire region is draggable when it should not be.
Actual Behavior
To not have a drag region if one is not specified
To Reproduce
I provided a small fiddle that showcases the problem. The green section of the fiddle at the top is the only place where there is actually a drag region set, but you can observe that the entire right side (150px) is also draggable.
https://gist.github.com/08f3e56e0a4dc443621bd769e18c7cd6
Screenshots
Additional Information
One other issue I've noticed is that a browserView on top of a browserWindow makes the overlapping part of the browserWindow lose draggability. e.g. if you set the top part of the browser window to be draggable, but then have a browserview over it, then the overlapping parts are not draggable even if the browserView does not have no-drag set. The only way I've found around this is to add another drag region at the top of the browserView, but this makes the phanton drag region at the side appear.