Skip to content

Windows crash on master branch #4127

@etiktin

Description

@etiktin

When you try to close the default app (built from 1b0da44) on Windows, the app crashes and you get the following output:

[10112:0116/021240:FATAL:scoped_handle.cc(44)] Check failed: false.
Backtrace:
        base::CommandLine::PrependWrapper [0x585BC7D7+148150]
        base::CommandLine::PrependWrapper [0x585DE557+286774]
        base::CommandLine::PrependWrapper [0x5864CE4F+739630]
        base::CommandLine::PrependWrapper [0x5864CEB1+739728]
        base::CommandLine::PrependWrapper [0x585D468B+246122]
        base::CommandLine::PrependWrapper [0x585C48BB+181146]
        asar::Archive::~Archive [0x00E59863+131] (c:\electron\atom\common\asar\archive.cc:135)
        asar::Archive::`scalar deleting destructor' [0x00E5A096+22]
        base::DefaultDeleter<asar::Archive>::operator() [0x00D5DBFD+61] (c:\electron\vendor\brightray\vendor\download\libchromiumcontent\src\base\memory\scoped_ptr.h:128)
        base::internal::scoped_ptr_impl<asar::Archive,base::DefaultDeleter<asar::Archive> >::reset [0x00D60D49+57] (c:\electron\vendor\brightray\vendor\download\libchromiumcontent\src\base\memory\scoped_ptr.h:239)
        scoped_ptr<asar::Archive,base::DefaultDeleter<asar::Archive> >::reset [0x00D60CFA+26] (c:\electron\vendor\brightray\vendor\download\libchromiumcontent\src\base\memory\scoped_ptr.h:366)
        `anonymous namespace'::Archive::Destroy [0x00D5E68B+27] (c:\electron\atom\common\api\atom_api_asar.cc:102)
        base::internal::RunnableAdapter<void (__thiscall `anonymous namespace'::Archive::*)(void)>::Run [0x00D6093B+27] (c:\electron\vendor\brightray\vendor\download\libchromiumcontent\src\base\bind_internal.h:176)
        base::internal::InvokeHelper<0,void,base::internal::RunnableAdapter<void (__thiscall `anonymous namespace'::Archive::*)(void)>,base::internal::TypeList<`anonymous namespace'::Archive * const &> >::MakeItSo [0x00D5FF5A+26] (c:\electron\vendor\brightray\vendor\download\libchromiumcontent\src\base\bind_internal.h:294)
        base::internal::Invoker<base::IndexSequence<>,base::internal::BindState<base::internal::RunnableAdapter<void (__thiscall `anonymous namespace'::Archive::*)(void)>,void __cdecl(`anonymous namespace'::Archive *),base::internal::TypeList<> >,base::internal:: [0x00D606BA+42] (c:\electron\vendor\brightray\vendor\download\libchromiumcontent\src\base\bind_internal.h:346)
        base::Callback<void __cdecl(`anonymous namespace'::Archive *)>::Run [0x00D603AC+60] (c:\electron\vendor\brightray\vendor\download\libchromiumcontent\src\base\callback.h:396)
        mate::internal::Invoker<mate::internal::IndicesHolder<0>,`anonymous namespace'::Archive *>::DispatchToCallback [0x00D5F1A0+64] (c:\electron\vendor\native_mate\native_mate\function_template.h:195)
        mate::internal::Dispatcher<void __cdecl(`anonymous namespace'::Archive *)>::DispatchToCallback [0x00D5EE5B+379] (c:\electron\vendor\native_mate\native_mate\function_template.h:229)
        v8::PersistentHandleVisitor::VisitPersistentHandle [0x588F73AE+27662]
        v8::ScriptCompiler::ExternalSourceStream::SetBookmark [0x587F3A7C+56748]
        v8::ScriptCompiler::ExternalSourceStream::SetBookmark [0x587F5DCD+65789]

This code in question was added in #4118.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions