-
-
Notifications
You must be signed in to change notification settings - Fork 133
Add Raspberry Pi build script #343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Let's drop live-build. I don't believe it is the right tool for this particular problem. Have you seen this rpi's official build script? This was my second option. I was only using live-build because I thought eOS was only interested in that. Knowing anything is on the table, I think we should really look at rpi's. Rpi build scripts are organzied quite well, the bash code is obviously tested from time, and editing would be fairly easy. The scripts and stages are easily digestible since it's just in numeric order. Tbh, I understood the rpi build scripts long before live-build. Live-build, as you said, is too clever. It's also handles cross compilation. I read they somewhere they build on an arm server to forgo cross compilation but eOS isn't forced into using different servers for different builds. I believe this is what we should be looking at to merge. Let me know what you think! |
Has anyone had any success with merging the two builds? |
Means we can keep the correct kernel version from focal
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@cassidyjames This has been tested on both a Pi 4 and 400 by both me and @meisenzahl now. Do you want to have final sign off on whether we're going ahead with this or not? We'll also need to make a PR to the builds site to show these. |
@davidmhewitt I tested the image a bit and was happy, if you both sign off, let's merge it |
Tested and confirmed working on Pi 400! 🎉