Skip to content

Conversation

davidmhewitt
Copy link
Member

@davidmhewitt davidmhewitt commented May 5, 2020

Tested and confirmed working on Pi 400! 🎉

@AndiLavera
Copy link

AndiLavera commented May 5, 2020

Let's drop live-build. I don't believe it is the right tool for this particular problem.

Have you seen this rpi's official build script?
https://github.com/RPi-Distro/pi-gen

This was my second option. I was only using live-build because I thought eOS was only interested in that. Knowing anything is on the table, I think we should really look at rpi's.

Rpi build scripts are organzied quite well, the bash code is obviously tested from time, and editing would be fairly easy. The scripts and stages are easily digestible since it's just in numeric order. Tbh, I understood the rpi build scripts long before live-build. Live-build, as you said, is too clever. It's also handles cross compilation. I read they somewhere they build on an arm server to forgo cross compilation but eOS isn't forced into using different servers for different builds.

I believe this is what we should be looking at to merge. Let me know what you think!

@hoytde81
Copy link

Has anyone had any success with merging the two builds?

@davidmhewitt davidmhewitt marked this pull request as ready for review November 25, 2020 21:00
Copy link
Member

@meisenzahl meisenzahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davidmhewitt
Copy link
Member Author

@cassidyjames This has been tested on both a Pi 4 and 400 by both me and @meisenzahl now. Do you want to have final sign off on whether we're going ahead with this or not?

We'll also need to make a PR to the builds site to show these.

@cassidyjames
Copy link
Contributor

@davidmhewitt I tested the image a bit and was happy, if you both sign off, let's merge it

@cassidyjames cassidyjames merged commit 44e7649 into master Dec 3, 2020
@cassidyjames cassidyjames deleted the raspi-build-script branch December 3, 2020 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants