Skip to content

Conversation

micahilbery
Copy link
Member

@micahilbery micahilbery commented Jul 1, 2021

This adds custom styles for syntax highlighting based on the elementary color palette.

fixes #29

@hanaral
Copy link

hanaral commented Jul 1, 2021

@micahilbery is this supposed to fix the long-standing issue of the highlight cursor colour in the solarised theme being the same?

@micahilbery
Copy link
Member Author

micahilbery commented Jul 1, 2021

@hanaral If you're talking about the bracket highlighting and selection highlighting being the same then yes this fixes that.
selection-vs-bracket-highlighting

@micahilbery micahilbery requested a review from a team July 1, 2021 16:02
@jeremypw
Copy link
Collaborator

jeremypw commented Jul 5, 2021

If you're talking about the bracket highlighting and selection highlighting being the same then yes this fixes that.

It looks like that the selection style is applied in preference to the bracket-match style so brackets that are both matching and selected only get the selection style. Presumably this behaviour is controlled by gtksourceview-4.

Copy link
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are pretty cool! The dark style is especially really pretty! I'm going to try to use these more daily and see where I notice any issues :)

One thing I noticed is that we're missing some fields that are provided by the classic style. Namely the git diff colors for the gutter: https://github.com/GNOME/gtksourceview/blob/master/data/styles/classic.xml#L110

@jeremypw
Copy link
Collaborator

jeremypw commented Nov 3, 2021

@micahilbery Will you be addressing the issue with gutter colors?

@micahilbery
Copy link
Member Author

Yes, I hope to work on it today. Sorry for the delay. My day job and seasonal plans have pretty well wiped out my free time.

@micahilbery
Copy link
Member Author

micahilbery commented Nov 10, 2021

I've updated the style so that we match classic and tested the git gutters. Afaict everything seems to be working as it should. Sorry this took me so long to get to.

@jeremypw
Copy link
Collaborator

Thanks - I'll try these out for a while to see if any issues arise.

@jeremypw
Copy link
Collaborator

I've merged this PR into my 'merge-dev-fixes- branch for dog-fooding.

Do far I've noticed that it is harder to see the selected text, especially for solarized-light:

ElementarySolarizedLightSelectedText

ElementarySolarizedDarkSelectedText

However, it is easier to distinguish selected brackets from highlighted brackets.

Is there a reason why selected text in the dark version is inverted in color whereas in the light version it isn't?

@jeremypw
Copy link
Collaborator

I can confirm that the gutter colors are now working.

@jeremypw
Copy link
Collaborator

@micahilbery I'm inclined to merge this as @danirabbit is 👍 Just one question: "Follow System Style" uses the standard "solarized-light" and "solarized-dark" styles - is that intended?

@jeremypw jeremypw dismissed danirabbit’s stale review October 22, 2022 15:10

Git diff colors fixed

Copy link
Collaborator

@jeremypw jeremypw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am going to go ahead and merge this as tweaks to themes can be done after further feedback.

@jeremypw jeremypw merged commit b5d84a1 into master Oct 22, 2022
@jeremypw jeremypw deleted the elementary-styles branch October 22, 2022 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Selected text and highlighted matching brackets are impossible to differentiate.
6 participants