PostHog ingestion warning due to repeated identification of already identified user #25187
Description
We're currently seeing around 2-3k daily ingestion warnings on PostHog.
Refused to merge already identified person
foo-bar-foointobla-bla-blavia an$identifyor$create_aliascall
Judging from the docs, these stem from attempting to call identify on an already identified user.
Browsing through the user list, many of them appear to be from Element Web so we should start the investigation here. The code already mentions a possible race condition but this isn't necessarily the root problem.
// Couldn't retrieve an analytics ID from user settings, so create one and set it on the server.
// Note there's a race condition here - if two devices do these steps at the same time, last write
// wins, and the first writer will send tracking with an ID that doesn't match the one on the server
// until the next time account data is refreshed and this function is called (most likely on next
// page load). This will happen pretty infrequently, so we can tolerate the possibility.