Skip to content

Some buttons on the header are tagged with the tab role without an associated element with the tabpanel role #25016

@luixxiul

Description

@luixxiul

Steps to reproduce

  • Create E2E test to select buttons inside HeaderButtons on the room header such as the thread button and the room info button with findByRole("button", {name: "" }).

Outcome

What did you expect?

The buttons should be able to be found.

What happened instead?

They were not found as they are tagged as tab.

Since the content rendered by clicking those buttons is not a tabbed content tagged with role="tabpanel", it should be fine to tag them as role="button".

https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/tab_role#description

I assume the role="tab" rather should be applied to the left column buttons on the setting dialogs, for example.

Operating system

No response

Browser information

No response

URL for webapp

No response

Application version

No response

Homeserver

No response

Will you send logs?

No

Metadata

Metadata

Assignees

Labels

A11yO-OccasionalAffects or can be seen by some users regularly or most users rarelyS-TolerableLow/no impact on usersT-Defect

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions