Skip to content

Hide "create account" registration links when registration is disabled (UIFeature.registration: false) #24814

@MadLittleMods

Description

@MadLittleMods

Spawning from a user report rageshake, https://github.com/matrix-org/element-web-rageshakes/issues/20495

Steps to reproduce

  1. Enable guest access on Element/Synapse
  2. Configure Element to disable registration UIFeature.registration: false
  3. Visit a room as a guest

First possibility:

  1. Open the user menu
  2. Click the Create an account link (this link should not be visible)
  3. Notice you're at a blank page /#/register

Second possibility

  1. Open the user menu -> Settings - > Create account

Outcome

What did you expect?

The create account buttons/link should not be visible when registration is disabled.

What happened instead?

The create account actions are visible and link to a blank registration page when registration is disabled.

Operating system

Windows 10

Browser information

Chrome Version 110.0.5481.180

URL for webapp

app.gitter.im

Application version

Element version: 1.11.24 Olm version: 3.2.12

Homeserver

gitter.im

Will you send logs?

No

Metadata

Metadata

Assignees

Labels

A-RegistrationO-UncommonMost users are unlikely to come across this or unexpected workflowS-TolerableLow/no impact on usersT-DefectZ-GitterIssues relating to or coming out of the Gitter migration, feature parity, etc

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions