Skip to content

Conversation

kaisecheng
Copy link
Contributor

Backports the following commits to 7.17:

This PR substitutes ${VAR} in Expression, except RegexValueExpression, with the value in secret store, env.
The substitution happens after syntax parsing and before graph execution.

Fixed: elastic#5115
Copy link
Member

@yaauie yaauie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic work. While the scope ended up being pretty hairy, I believe that you are right in calling this a bug-fix. I'll merge shortly so we can get this into 7.17.0.

@yaauie yaauie merged commit d2a98a0 into elastic:7.17 Jan 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants