Skip to content

Conversation

fin09pcap
Copy link
Member

@fin09pcap fin09pcap commented Jun 23, 2023

Update the cmdutil.Reader to use os.Openfile.
Add additional details for error formatting to assist debugging.

@fin09pcap fin09pcap self-assigned this Jun 23, 2023
fix: update logic to include os.Stat
fix: remove use of filepath.Clean
fix: update name to not colide with package, i.e bytes
fix: update logic to not change directories but use the file path name

Signed-off-by: Ben Stickel <ben.stickel@elastic.co>
Signed-off-by: Ben Stickel <ben.stickel@elastic.co>
Requires introspection into failure for pkg pkg/container/seal/v2

Signed-off-by: Ben Stickel <ben.stickel@elastic.co>
Signed-off-by: Ben Stickel <ben.stickel@elastic.co>
Signed-off-by: Ben Stickel <ben.stickel@elastic.co>
Signed-off-by: Ben Stickel <ben.stickel@elastic.co>
@fin09pcap fin09pcap marked this pull request as ready for review June 26, 2023 20:53
@fin09pcap fin09pcap requested review from renanvice and a team June 26, 2023 20:53
@fin09pcap fin09pcap added the bug Something isn't working label Jun 26, 2023
@fin09pcap fin09pcap changed the title fix: add retry attempt to the cmdutil.Reader fix: update cmdutil.Reader to use os.Openfile Jun 26, 2023
@fin09pcap fin09pcap merged commit 9c6967f into elastic:main Jun 27, 2023
@fin09pcap fin09pcap deleted the bug/readerRetry branch June 27, 2023 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants