Skip to content

[config] Config values are not honored with the command line flag #186

@fin09pcap

Description

@fin09pcap

What version of Go are you using (go version)?

$ go version
go version go1.18.1 darwin/arm64

Does this issue reproduce with the latest release?

Yes.

What operating system and processor architecture are you using (go env)?

go env Output
$ go env
GO111MODULE=""
GOARCH="arm64"
GOBIN=""
GOCACHE="/Users/fin09pcap/Library/Caches/go-build"
GOENV="/Users/fin09pcap/Library/Application Support/go/env"
GOEXE=""
GOEXPERIMENT=""
GOFLAGS=""
GOHOSTARCH="arm64"
GOHOSTOS="darwin"
GOINSECURE=""
GOMODCACHE="/Users/fin09pcap/go/pkg/mod"
GONOPROXY=""
GONOSUMDB=""
GOOS="darwin"
GOPATH="/Users/fin09pcap/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/Users/fin09pcap/.go"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/Users/fin09pcap/.go/pkg/tool/darwin_arm64"
GOVCS=""
GOVERSION="go1.18.1"
GCCGO="gccgo"
AR="ar"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD="/dev/null"
GOWORK=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -arch arm64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/lp/ql182cbs1s55lq4nk5zwg1g00000gn/T/go-build3701245895=/tmp/go-build -gno-record-gcc-switches -fno-common"
GOROOT/bin/go version: go version go1.18.1 darwin/arm64
GOROOT/bin/go tool compile -V: compile version go1.18.1
uname -v: Darwin Kernel Version 21.4.0: Fri Mar 18 00:46:32 PDT 2022; root:xnu-8020.101.4~15/RELEASE_ARM64_T6000
ProductName:	macOS
ProductVersion:	12.3.1
BuildVersion:	21E258
lldb --version: lldb-1316.0.9.41
Apple Swift version 5.6 (swiftlang-5.6.0.323.62 clang-1316.0.20.8)

What version of Secret are you using (harp version)?

$ harp version
0.2.10 [main:2022-03-13T16:51:55Z] (Go: go1.17.7 darwin/arm64, Flags: defaults, Date: 2022-03-13T16:59:24Z)

What did you do?

harp config new > config.toml
$ harp config new > config.toml
$ cat config.toml

###############################
# Debug
###############################
[Debug]

  # allow debug mode
  enable = false

###############################
# Instrumentation
###############################
[Instrumentation]

  # Listen address for instrumentation server
  listen = ":5556"

  # Network class used for listen (tcp, tcp4, tcp6, unixsocket)
  network = "tcp"

  ###############################
  # Diagnotic Settings
  ###############################
  [Instrumentation.Diagnostic]

    # Enable diagnostic handlers
    enabled = false

    # Diagnostic settings
    [Instrumentation.Diagnostic.Config]

      [Instrumentation.Diagnostic.Config.GOPS]

        # Enable GOPS agent
        enabled = false

        # start a gops agent on specified URL. Ex: localhost:9999
        remoteDebugURL = ""

      [Instrumentation.Diagnostic.Config.PProf]

        # Enable PProf handler
        enabled = true

      [Instrumentation.Diagnostic.Config.ZPages]

        # Enable zPages handler
        enabled = true

  ###############################
  # Logs Settings
  ###############################
  [Instrumentation.Logs]

    # Log level: debug, info, warn, error, dpanic, panic, and fatal
    level = "warn"

Modify the debug settings to true.

What did you expect to see?

Debug output is enabled via the command line flag.

What did you see instead?

$ harp --config config.toml bundle dump --in test.bundle
Error: unknown flag: --config
Usage:
  harp bundle dump [flags]

Examples:
  # Dump a JSON representation of a Bundle object from STDIN
  harp bundle dump

  # Dump a JSON map containing package name as key and associated secret kv
  harp bundle dump --data-only

  # Dump a JSON map containing package name as key and associated metadata
  harp bundle dump --metadata-only

  # Dump all package paths as a list (useful for xargs usage)
  harp bundle dump --path-only

  # Dump a Bundle using a JMEFilter query
  harp bundle dump --query <jmesfilter query>

  # Dump a bundle content excluding the template used to generate
  harp bundle dump --skip-template

Flags:
      --content-only    Display content only (data-only alias)
      --data-only       Display data only
  -h, --help            help for dump
      --in string       Container input ('-' for stdin or filename)
      --metadata-only   Display metadata only
      --path-only       Display path only
      --query string    Specify a JMESPath query to format output
      --skip-template   Drop template from dump

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions