[Zen2] Only elect master-eligible nodes #35996
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Today any node can win an election. However, the whole point of master-eligibility is that master-ineligible nodes should not be elected as the leader; furthermore master-ineligible nodes do not have any outgoing STATE channels so cannot publish cluster states, so their leadership is ineffective and disruptive. This change ensures that the elected leader is master-eligible by preventing master-ineligible nodes from scheduling an election.
|
Pinging @elastic/es-distributed |
ywelsch
reviewed
Nov 28, 2018
| internalCluster().startDataOnlyNode(); | ||
| internalCluster().stopCurrentMasterNode(); | ||
| // There's only one master-eligible node left so it should elect itself pretty quickly. | ||
| assertFalse(client().admin().cluster().prepareHealth().setTimeout(TimeValue.timeValueSeconds(10)).get().isTimedOut()); |
There was a problem hiding this comment.
can we write this as a CoordinatorTest?
There was a problem hiding this comment.
We can - see 2de0feb.
61 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today any node can win an election. However, the whole point of
master-eligibility is that master-ineligible nodes should not be elected as the
leader; furthermore master-ineligible nodes do not have any outgoing STATE
channels so cannot publish cluster states, so their leadership is ineffective
and disruptive.
This change ensures that the elected leader is master-eligible by preventing
master-ineligible nodes from scheduling an election.