-
Notifications
You must be signed in to change notification settings - Fork 447
[RFC 0050] [Update] Stage 2: Introducing GenAI fields #2489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Documentation changes preview: https://docs-v3-preview.elastic.dev/elastic/ecs/pull/2489/reference/ |
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
LGTM
I am not sure what you mean. Most (or all) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Optional suggestion to disable indexing for the description field, otherwise LGTM.
Thanks @eyalkoren this is clear enough to me! I just wanted to make sure I wasn't missing something
|
Co-authored-by: Felix Barnsteiner <felixbarny@users.noreply.github.com>
cc @trisch-me @mjwolf regarding updating This came up as part of: |
Thank you, @trisch-me ! |
description: Free-form description of the GenAI agent provided by the application. | ||
example: Helps with math problems; Generates fiction stories | ||
index: false | ||
doc_values: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's curious that doc_values is also false now but just setting index: false
in the schema.
Is it possible to explicitly set doc_values: true
in here to retain it in the mappings (and to keep ignore_above
)?
Lines 29 to 37 in a1237a3
- name: agent.description | |
type: keyword | |
index: false | |
description: Free-form description of the GenAI agent provided by the application. | |
example: Helps with math problems; Generates fiction stories | |
level: extended | |
beta: This field is beta and subject to change. | |
otel: | |
- relation: match |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for pointing this out! - To summarize what we discussed on the Elasticsearch issue we'll merge first and then continue to adjust in the upcoming weeks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@felixbarny It's possible to explicitly set doc_values: true
, and it will be applied in the generated files.
I've created an ECS issue to update the generator: #2492.
Should ignore_above: 1024
be set as the default value for all keywords? I can add that to the issue to update the generator too.
Overview
This PR proposes changes on top of
based on discussion with @felixbarny @eyalkoren in this PR:
namely, updating
gen_ai.request.model
andgen_ai.agent.description
fromtext
tokeyword
.The rationale:
gen_ai.request.model
: doesn't require text analyzinggen_ai.agent.description
: phrase queries may not be used often for this field, and may be expensive from storage and indexing - via @felixbarnyI'm looking for feedback if this is covered, as it's part of the generated files and I'm not completely sure which changes are expected forignore_above
to work.Checklist
make test
?make
and committed those changes?