Skip to content

Conversation

mjwolf
Copy link
Contributor

@mjwolf mjwolf commented Jun 3, 2025

For fieldsets with underscores, the generated otel field links were not correct, resulting in 404 when trying to follow the link.

This generates the correct url for these fields.

  • Have you signed the contributor license agreement? y
  • Have you followed the contributor guidelines? y
  • For proposing substantial changes or additions to the schema, have you reviewed the RFC process? n/a
  • If submitting code/script changes, have you verified all tests pass locally using make test? y
  • If submitting schema/fields updates, have you generated new artifacts by running make and committed those changes? y
  • Is your pull request against main? Unless there is a good reason otherwise, we prefer pull requests against main and will backport as needed. y
  • Have you added an entry to the CHANGELOG.next.md? y

For fieldsets with underscores, the generated otel field links were not
correct, resulting in 404 when trying to follow the link.

This generates the correct url for these fields.
@mjwolf mjwolf requested a review from a team as a code owner June 3, 2025 17:32
Copy link

github-actions bot commented Jun 3, 2025

Documentation changes preview: https://docs-v3-preview.elastic.dev/elastic/ecs/pull/2486/reference/

Copy link

github-actions bot commented Jun 3, 2025

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@mjwolf mjwolf changed the title Fix otel urls for fieldsets with underscores Fix otel urls in documentation for fieldsets with underscores Jun 3, 2025
@trisch-me trisch-me merged commit 5f10d08 into elastic:main Jun 5, 2025
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants