Skip to content

Conversation

ebeahan
Copy link
Member

@ebeahan ebeahan commented Sep 20, 2023

Remove field sets with reusable.top_level: false from erroneously appearing as valid, top-level fields in generated/beats/fields.ecs.yml.

The same check is now performed on both the ES template and Beats fields generators.

Fixes #2277

@ebeahan ebeahan requested a review from a team as a code owner September 20, 2023 18:53
@ebeahan ebeahan self-assigned this Sep 20, 2023
Copy link
Contributor

@kgeller kgeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ebeahan ebeahan merged commit 7c374fe into elastic:main Sep 25, 2023
@ebeahan ebeahan deleted the beats-top-level-handling branch September 25, 2023 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect generated/beats/fields.ecs.yml, not accounting on top_level: false
2 participants