fix: add date format used by AWS for CreateTime on ASGs #97
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Maggie Chen <magchen@redhat.com>
|
@ekristen ^^ |
|
@chenz4027 thanks! this was definitely an oversight in the rewrite. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #97 +/- ##
=======================================
Coverage 98.92% 98.92%
=======================================
Files 19 19
Lines 1679 1680 +1
=======================================
+ Hits 1661 1662 +1
Misses 13 13
Partials 5 5 ☔ View full report in Codecov by Sentry. |
|
🎉 This pull request is included in version 0.24.3 🎉 The release is available on GitHub release 🚀 |
|
Thanks @ekristen 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to add the date format used by AWS for CreateTime on ASGs. It caused a regression on our migration from v2 to v3 since this format is no longer supported. Error was
unable to parse time 2023-12-20 09:00:03.066 +0000 UTCSeems like this format wasn't ported over.
https://github.com/rebuy-de/aws-nuke/blob/main/pkg/config/filter.go#L87-L94
vs
https://github.com/ekristen/libnuke/blame/main/pkg/filter/filter.go#L361-L365