feat: libnuke@1.2.0 and resource unique keys #686
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎉 This PR is included in version 3.56.1-beta.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 3.56.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This upgrades to libnuke 1.2.0 that introduces a new unique key feature both via an interface on the resource type or via structure tags.
This feature allows resources to indicate which property or properties can be used to identify the resource as unique. One primary example of this is CloudWatch Log Groups. They do not have a unique ID like an ARN, instead they need to be considered unique via their Name and CreateTime, therefore these fields combined create a unique key.
This unique key is not exposed to the user of the tool, it is instead used by libnuke to determine if a resource has been deleted and to solve a problem we've been trying to solve using the stringer and properties for a while.
With this change resources are compared in the following order...
References