[ISSUE-455] showEnvVariableValues code ported, one bugfix #458
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9e624a6 to
6e55a38
Compare
kastoestoramadus
commented
Jul 9, 2025
sconfig/shared/src/main/scala/org/ekrich/config/ConfigRenderOptions.scala
Show resolved
Hide resolved
6e55a38 to
aba1406
Compare
aba1406 to
3379df1
Compare
kastoestoramadus
commented
Jul 9, 2025
ekrich
requested changes
Jul 9, 2025
sconfig/shared/src/main/scala/org/ekrich/config/impl/AbstractConfigValue.scala
Show resolved
Hide resolved
Sets on old fields were not copying/preserving the formatting options. By removing default value it you may check all places where it is used. |
ad3ee0b to
f81ecf3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ekrich
Ready for review.
Green tests.
#455