Skip to content

docs: added missing --region flag in the for nodegroup and iamidentitymapping pages #4521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 9, 2021
Merged

docs: added missing --region flag in the for nodegroup and iamidentitymapping pages #4521

merged 1 commit into from
Dec 9, 2021

Conversation

herlon214
Copy link
Contributor

Description

I added the missing --region flag in the docs page for nodegroup and also iamidentitymapping. As pointed in the issue iamidentitymapping by @todd-dsm

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes
  • (Core team) Added labels for change area (e.g. area/nodegroup) and kind (e.g. kind/improvement)

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

@Skarlso Skarlso added the kind/docs User documentation label Dec 9, 2021
@Skarlso
Copy link
Contributor

Skarlso commented Dec 9, 2021

Fine from me! Thank you for your contribution! :)

@Skarlso
Copy link
Contributor

Skarlso commented Dec 9, 2021

Just waiting for a second pair of eyes. :)

@aclevername aclevername merged commit 1b506e1 into eksctl-io:main Dec 9, 2021
@aclevername
Copy link
Contributor

Thanks @herlon214 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Himangini Himangini Awaiting requested review from Himangini

@nikimanoledaki nikimanoledaki Awaiting requested review from nikimanoledaki

2 more reviewers

@Skarlso Skarlso Skarlso approved these changes

@aclevername aclevername aclevername approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
kind/docs User documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@herlon214 @Skarlso @aclevername