Skip to content

Add integration test for associate, disassociate and get identityprovider #4501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Dec 13, 2021
Merged

Add integration test for associate, disassociate and get identityprovider #4501

merged 6 commits into from
Dec 13, 2021

Conversation

cPu1
Copy link
Contributor

@cPu1 cPu1 commented Nov 30, 2021 •
edited
Loading

Description

Closes #4443, #4444, #4445

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes
  • (Core team) Added labels for change area (e.g. area/nodegroup) and kind (e.g. kind/improvement)

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

@cPu1 cPu1 force-pushed the identity-provider-test branch from b262067 to 410bb8c Compare November 30, 2021 13:23
@cPu1 cPu1 added area/testing area/tech-debt Leftover improvements in code, testing and building labels Nov 30, 2021
@cPu1 cPu1 force-pushed the identity-provider-test branch 2 times, most recently from 48958df to a47d4ae Compare November 30, 2021 14:36
@cPu1 cPu1 force-pushed the identity-provider-test branch from 1852447 to 012a982 Compare December 1, 2021 10:50
cPu1
cPu1 commented Dec 1, 2021
View reviewed changes
integration/tests/identity_provider/identity_provider_test.go
UserPoolId: pool.UserPool.Id,
GenerateSecret: aws.Bool(false),
SupportedIdentityProviders: aws.StringSlice([]string{"COGNITO"}),
// TODO this is likely not required, check if this can be removed.
Copy link
Contributor Author

@cPu1 cPu1 Dec 1, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am going to open another issue for this, as it requires changing values for other fields.

@cPu1
Copy link
Contributor Author

cPu1 commented Dec 1, 2021

Integration test passed locally.

Himangini
Himangini approved these changes Dec 2, 2021
View reviewed changes
Copy link
Contributor

@Himangini Himangini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

Skarlso
Skarlso reviewed Dec 2, 2021
View reviewed changes
@cPu1 cPu1 force-pushed the identity-provider-test branch 3 times, most recently from 0b77051 to a5ab8be Compare December 8, 2021 11:02
@aclevername
Copy link
Contributor

Integration test passed locally.

have you re-ran since the changes were made? Do we need any additional policies for out github action role to hit these APIs?

@cPu1
Copy link
Contributor Author

cPu1 commented Dec 9, 2021

have you re-ran since the changes were made?

The tests are in progress right now.

Do we need any additional policies for out github action role to hit these APIs?

We do. I'm going to work on adding them.

@cPu1
Copy link
Contributor Author

cPu1 commented Dec 9, 2021

The tests are in progress right now.

Integration tests passed for the new changes.

@aclevername
Copy link
Contributor

have you re-ran since the changes were made?

The tests are in progress right now.

Do we need any additional policies for out github action role to hit these APIs?

We do. I'm going to work on adding them.

lets make sure the role & cf tempalte in eksctl-ci are updated before merging

@cPu1 cPu1 force-pushed the identity-provider-test branch from a5ab8be to 53b1c78 Compare December 13, 2021 08:52
@cPu1
Copy link
Contributor Author

cPu1 commented Dec 13, 2021

have you re-ran since the changes were made?

The tests are in progress right now.

Do we need any additional policies for out github action role to hit these APIs?

We do. I'm going to work on adding them.

lets make sure the role & cf tempalte in eksctl-ci are updated before merging

Yeah, that's why I haven't merged it yet. I'm running the tests now after updating the role.

@cPu1 cPu1 merged commit 3d469a0 into eksctl-io:main Dec 13, 2021
This was referenced Dec 14, 2021
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikimanoledaki nikimanoledaki Awaiting requested review from nikimanoledaki

3 more reviewers

@Himangini Himangini Himangini approved these changes

@aclevername aclevername aclevername left review comments

@Skarlso Skarlso Skarlso approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
area/tech-debt Leftover improvements in code, testing and building area/testing kind/improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Integration test for eksctl associate identityprovider command
4 participants
@cPu1 @aclevername @Skarlso @Himangini