Skip to content

Conversation

aclevername
Copy link
Contributor

@aclevername aclevername commented Nov 18, 2021

Description

Closes #2963

Removed commands:

  • eksctl enable repo
  • eksctl generate

Updated commands:

  • eksctl enable flux now only supports v2
  • eksctl create cluster now only supports v2

Before:

rg "FLUX V1 DEPRECATION NOTICE" | wc -l
34

After:

rg "FLUX V1 DEPRECATION NOTICE" | wc -l
0

Reviewing

See the second commit for the update to documentation

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes
  • (Core team) Added labels for change area (e.g. area/nodegroup) and kind (e.g. kind/improvement)

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

@aclevername aclevername force-pushed the remove-flux1 branch 3 times, most recently from 8edd81d to fbd6e59 Compare November 18, 2021 10:27
Copy link
Contributor

@Skarlso Skarlso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 🎉

Copy link
Contributor

@nikimanoledaki nikimanoledaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a couple of suggestions, otherwise LGTM! :)

kind: ClusterConfig

metadata:
name: cluster-21
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bit nit but removing this file will break the ordering in examples/.. could move/rename another one (the last one?) in examples/ as 21-foo. wdyt?

"gitops": {
"$ref": "#/definitions/GitOps",
"description": "exposes configuration for Flux v2 and will continue to be used in future gitops plans, replacing the Git configuration above",
"x-intellij-html-description": "exposes configuration for Flux v2 and will continue to be used in future gitops plans, replacing the Git configuration above"
"description": "future gitops plans, replacing the Git configuration above",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this need to be updated?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good spot!

@aclevername aclevername merged commit debd9f9 into eksctl-io:main Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Eksctl gitops v1 deprecation
3 participants