-
Notifications
You must be signed in to change notification settings - Fork 1.5k
remove flux1 & profiles support #4471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
8edd81d
to
fbd6e59
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a couple of suggestions, otherwise LGTM! :)
kind: ClusterConfig | ||
|
||
metadata: | ||
name: cluster-21 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bit nit but removing this file will break the ordering in examples/
.. could move/rename another one (the last one?) in examples/
as 21-foo
. wdyt?
"gitops": { | ||
"$ref": "#/definitions/GitOps", | ||
"description": "exposes configuration for Flux v2 and will continue to be used in future gitops plans, replacing the Git configuration above", | ||
"x-intellij-html-description": "exposes configuration for Flux v2 and will continue to be used in future gitops plans, replacing the Git configuration above" | ||
"description": "future gitops plans, replacing the Git configuration above", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does this need to be updated?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good spot!
0bfc720
to
fef80f2
Compare
Description
Closes #2963
Removed commands:
eksctl enable repo
eksctl generate
Updated commands:
eksctl enable flux
now only supports v2eksctl create cluster
now only supports v2Before:
After:
Reviewing
See the second commit for the update to documentation
Checklist
README.md
, or theuserdocs
directory)area/nodegroup
) and kind (e.g.kind/improvement
)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯