Skip to content

Support scaling all nodegroups found in a config file #4464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 24, 2021
Merged

Support scaling all nodegroups found in a config file #4464

merged 4 commits into from
Nov 24, 2021

Conversation

nikimanoledaki
Copy link
Contributor

@nikimanoledaki nikimanoledaki commented Nov 16, 2021 •
edited
Loading

Description

Closes #2655

This PR addresses the second part of that issue e.g. Also would be great if --name could be omitted (not required) in which case ALL nodegroups would be scaled to current supplied config spec.

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes
  • (Core team) Added labels for change area (e.g. area/nodegroup) and kind (e.g. kind/improvement)

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

@nikimanoledaki nikimanoledaki added the kind/feature New feature or request label Nov 16, 2021
@nikimanoledaki nikimanoledaki changed the title Support scaling all nodegroups found in config file Support scaling all nodegroups found in a config file Nov 16, 2021
@nikimanoledaki nikimanoledaki force-pushed the scale-all-nodes branch 6 times, most recently from 21c56cb to c0fb213 Compare November 17, 2021 11:08
@nikimanoledaki nikimanoledaki marked this pull request as ready for review November 17, 2021 11:08
aclevername
aclevername reviewed Nov 17, 2021
View reviewed changes
aclevername
aclevername reviewed Nov 17, 2021
View reviewed changes
aclevername
aclevername reviewed Nov 17, 2021
View reviewed changes
@Himangini
Copy link
Contributor

⭐ for ticking all the boxes in description 🎉

aclevername
aclevername reviewed Nov 17, 2021
View reviewed changes
aclevername
aclevername reviewed Nov 17, 2021
View reviewed changes
Skarlso
Skarlso reviewed Nov 17, 2021
View reviewed changes
Skarlso
Skarlso reviewed Nov 17, 2021
View reviewed changes
@nikimanoledaki nikimanoledaki force-pushed the scale-all-nodes branch 4 times, most recently from fc8fa58 to bc81a5b Compare November 19, 2021 11:33
Himangini
Himangini approved these changes Nov 19, 2021
View reviewed changes
Copy link
Contributor

@Himangini Himangini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

@nikimanoledaki nikimanoledaki merged commit 020d876 into eksctl-io:main Nov 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cPu1 cPu1 Awaiting requested review from cPu1

@aclevername aclevername Awaiting requested review from aclevername

@Skarlso Skarlso Awaiting requested review from Skarlso

1 more reviewer

@Himangini Himangini Himangini approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
kind/feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

eksctl scale nodegroup --config-file --name <nodegroup>: node group <nodegroup> not found
4 participants
@nikimanoledaki @Himangini @Skarlso @aclevername