Update aws-node #4374
Closed
Update aws-node #4374
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aclevername
reviewed
Oct 28, 2021
| @@ -64,7 +64,7 @@ | |||
| - "list" | |||
| - "watch" | |||
| --- | |||
| "apiVersion": "apiextensions.k8s.io/v1beta1" | |||
| "apiVersion": "apiextensions.k8s.io/v1" | |||
There was a problem hiding this comment.
looks like a non-breaking change thankfully https://kubernetes.io/docs/reference/using-api/deprecation-guide/#customresourcedefinition-v122
There was a problem hiding this comment.
do we need to run the integration tests on this branch before merging?
There was a problem hiding this comment.
think we should be okay, it will run after its merged before its released in the worst case scenario
aclevername
approved these changes
Oct 28, 2021
Skarlso
approved these changes
Oct 29, 2021
|
Closing in favour of #4391 as I cba with merge conflicts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.