Skip to content

Validate support for GPU instance types #4243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 18, 2021
Merged

Validate support for GPU instance types #4243

merged 5 commits into from
Oct 18, 2021

Conversation

cPu1
Copy link
Contributor

@cPu1 cPu1 commented Sep 23, 2021 •
edited
Loading

Description

Closes #4238

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes
  • (Core team) Added labels for change area (e.g. area/nodegroup) and kind (e.g. kind/improvement)

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

@cPu1 cPu1 added the kind/bug label Sep 23, 2021
@cPu1 cPu1 force-pushed the gpu-ami-fix branch 2 times, most recently from 5540899 to d56e08b Compare September 23, 2021 08:24
@cPu1 cPu1 marked this pull request as draft September 23, 2021 08:31
@cPu1 cPu1 force-pushed the gpu-ami-fix branch 2 times, most recently from 5fd1619 to 26b3f36 Compare September 23, 2021 10:40
@cPu1 cPu1 marked this pull request as ready for review September 23, 2021 10:45
@cPu1 cPu1 force-pushed the gpu-ami-fix branch 2 times, most recently from 7f90a19 to 1e91749 Compare September 27, 2021 12:46
@aclevername
Copy link
Contributor

is this ready for review? (haven't been requested)

@cPu1
Copy link
Contributor Author

cPu1 commented Oct 13, 2021

is this ready for review? (haven't been requested)

Yes, it's ready for review. I missed your comment.

@cPu1
Copy link
Contributor Author

cPu1 commented Oct 13, 2021

This is a breaking change as explained in this pinned issue.

aclevername
aclevername approved these changes Oct 13, 2021
View reviewed changes
Copy link
Contributor

@aclevername aclevername left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😄

Skarlso
Skarlso reviewed Oct 13, 2021
View reviewed changes
integration/tests/instance_selector/instance_selector_test.go Outdated
@@ -6,10 +6,11 @@ package instance_selector
import (
"testing"

instanceutils "github.com/weaveworks/eksctl/pkg/utils/instance"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please move this down to the rest of the eksctl specific imports? :) Thanks :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done :)

@cPu1 cPu1 merged commit f4fbe1c into eksctl-io:main Oct 18, 2021
@doctorpangloss doctorpangloss mentioned this pull request Apr 12, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Himangini Himangini Awaiting requested review from Himangini

@nikimanoledaki nikimanoledaki Awaiting requested review from nikimanoledaki

2 more reviewers

@Skarlso Skarlso Skarlso left review comments

@aclevername aclevername aclevername approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
kind/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Breaking] Remove incomplete support for GPU instance types in Bottlerocket and Windows nodegroups
3 participants
@cPu1 @aclevername @Skarlso