Skip to content

Automatically attach the correct EBS CSI Driver policies when creating the addon #4216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 15, 2021
Merged

Automatically attach the correct EBS CSI Driver policies when creating the addon #4216

merged 3 commits into from
Dec 15, 2021

Conversation

aclevername
Copy link
Contributor

@aclevername aclevername commented Sep 15, 2021 •
edited
Loading

Description

Closes #4188

DO NOT MERGE UNTIL THE ADDON IS RELEASED

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes
  • (Core team) Added labels for change area (e.g. area/nodegroup) and kind (e.g. kind/improvement)

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

@aclevername aclevername added the kind/feature New feature or request label Sep 15, 2021
aclevername
aclevername commented Sep 15, 2021
View reviewed changes
@aclevername aclevername marked this pull request as ready for review November 16, 2021 16:53
Himangini
Himangini approved these changes Nov 17, 2021
View reviewed changes
Copy link
Contributor

@Himangini Himangini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻 use the second pair of eyes as I may not have all the context :D

@Himangini
Copy link
Contributor

Does the description need an update? It says Do not merge 😅

@aclevername
Copy link
Contributor Author

Does the description need an update? It says Do not merge sweat_smile

nah it still can't be merged yet, but its to discuss at standup

@aclevername
Copy link
Contributor Author

tested:

apiVersion: eksctl.io/v1alpha5
kind: ClusterConfig
metadata:
  name: jk-ebs
  region: us-west-2
  version: "1.18"

iam:
  withOIDC: true

managedNodeGroups:
  - name: mng1

addons:
- name: vpc-cni # no version is specified so it deploys the default version
  attachPolicyARNs:
    - arn:aws:iam::aws:policy/AmazonEKS_CNI_Policy
- name: coredns
  version: latest # auto discovers the latest available
- name: kube-proxy
  version: latest
- name: aws-ebs-csi-driver
  version: latest

2021-12-15 15:22:17 [ℹ]  creating role using recommended policies
2021-12-15 15:22:17 [ℹ]  creating role using provided well known policies
2021-12-15 15:22:19 [ℹ]  deploying stack "eksctl-jk-ebs-addon-aws-ebs-csi-driver"
2021-12-15 15:22:19 [ℹ]  waiting for CloudFormation stack "eksctl-jk-ebs-addon-aws-ebs-csi-driver"
2021-12-15 15:22:35 [ℹ]  waiting for CloudFormation stack "eksctl-jk-ebs-addon-aws-ebs-csi-driver"
2021-12-15 15:22:55 [ℹ]  waiting for CloudFormation stack "eksctl-jk-ebs-addon-aws-ebs-csi-driver"
2021-12-15 15:23:16 [ℹ]  waiting for CloudFormation stack "eksctl-jk-ebs-addon-aws-ebs-csi-driver"
2021-12-15 15:23:17 [ℹ]  creating addon
2021-12-15 15:25:48 [ℹ]  addon "aws-ebs-csi-driver" active
2021-12-15 15:25:51 [ℹ]  kubectl command should work with "/home/jake/.kube/config", try 'kubectl get nodes'
2021-12-15 15:25:51 [✔]  EKS cluster "jk-ebs" in "us-west-2" region is ready
jake@jake-weave [15:33:43] [~/weave/eksctl] [csi-drivei *]
-> % k get pods -A
NAMESPACE     NAME                                  READY   STATUS    RESTARTS   AGE
kube-system   aws-node-c4xnl                        1/1     Running   1          19m
kube-system   aws-node-dvrff                        1/1     Running   1          19m
kube-system   coredns-5cc8c6c8c4-cmthw              1/1     Running   0          16m
kube-system   coredns-5cc8c6c8c4-ttqnv              1/1     Running   0          16m
kube-system   ebs-csi-controller-56488f974d-9769q   4/4     Running   0          10m
kube-system   ebs-csi-controller-56488f974d-pdlfr   4/4     Running   0          10m
kube-system   ebs-csi-node-bq8l7                    3/3     Running   0          10m

@aclevername aclevername merged commit 076e806 into eksctl-io:main Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikimanoledaki nikimanoledaki Awaiting requested review from nikimanoledaki

@cPu1 cPu1 Awaiting requested review from cPu1

2 more reviewers

@Skarlso Skarlso Skarlso approved these changes

@Himangini Himangini Himangini approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
kind/feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Automatically attach the correct EBS CSI Driver policies when creating the addon
3 participants
@aclevername @Himangini @Skarlso