Skip to content

instanceSelector support for allow/deny list #3718

@kr3cj

Description

@kr3cj

We are starting to use the instanceSelector feature in some our EKS configs. It greatly simplifies our configuration and is easier to understand. Thank you for this feature.

However, in order to use it everywhere, we would need to be able to specify some kind of allow/deny list for specific instanceTypes.

The reason we need this is because we've performed profiling of different instance classes with our workloads and found that certain ones aren't something we want to adopt in production (t3 specifically). They're good for staging/dev environments but for production, we try to stick with other instance classes.

We noticed that the underlying ec2-instance-selector already supports the following arguments:

      --allow-list string                 List of allowed instance types to select from w/ regex syntax (Example: m[3-5]\.*)
      --deny-list string                 List of instance types which should be excluded w/ regex syntax (Example: m[1-2]\.*)

It would be great if those could be exposed in the eksctl config schema. Something like:

managedNodeGroups:
  - name: my-node-group
    instanceSelector:
      vCPUs: 4
      memory: "16"
      allow: "[cm]5\.*"

Or

managedNodeGroups:
  - name: my-node-group
    instanceSelector:
      vCPUs: 4
      memory: "16"
      deny: "t\.*"

This came out of the discussion on #3531 (comment)

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions