Skip to content

Conversation

kwk
Copy link
Contributor

@kwk kwk commented Mar 6, 2025

Fix #427

--skip

since 2023-09-14 (v1.21), removed 2024-05-26 (v2.0)

The following goreleaser release flags were deprecated:

--skip-announce
--skip-before
--skip-docker
--skip-ko
--skip-publish
--skip-sbom
--skip-sign
--skip-validate

See https://goreleaser.com/deprecations/#-skip

This also fixes a problem with the version of the .goreleaser.yml
which now has to be version: 2.

In order for the github workflow to not error with this message:

$ goreleaser check
  • by using this software you agree with its EULA, available at https://goreleaser.com/eula
  • running goreleaser v2.7.0
  • checking                                 path=.goreleaser.yml
  • DEPRECATED:  snapshot.name_template  should not be used anymore, check https://goreleaser.com/deprecations#snapshotname_template for more info
  • DEPRECATED:  archives.format_overrides.format  should not be used anymore, check https://goreleaser.com/deprecations#archivesformat_overridesformat for more info
  • .goreleaser.yml                                  error=configuration is valid, but uses deprecated properties
  ⨯ command failed                                   error=1 out of 1 configuration file(s) have https://black.readthedocs.io/en/stable/integrations/source_version_control.html

I had to update the .gorelease.yml according to the DEPRECATED links in the output above.

> --skip
>
>     since 2023-09-14 (v1.21), removed 2024-05-26 (v2.0)
>
> The following goreleaser release flags were deprecated:
>
>     --skip-announce
>     --skip-before
>     --skip-docker
>     --skip-ko
>     --skip-publish
>     --skip-sbom
>     --skip-sign
>     --skip-validate

See https://goreleaser.com/deprecations/#-skip

This also fixes a problem with the version of the `.goreleaser.yml`
which now has to be `version: 2`.

In order for the github workflow to not error with this message:

```console
$ goreleaser check
  • by using this software you agree with its EULA, available at https://goreleaser.com/eula
  • running goreleaser v2.7.0
  • checking                                 path=.goreleaser.yml
  • DEPRECATED:  snapshot.name_template  should not be used anymore, check https://goreleaser.com/deprecations#snapshotname_template for more info
  • DEPRECATED:  archives.format_overrides.format  should not be used anymore, check https://goreleaser.com/deprecations#archivesformat_overridesformat for more info
  • .goreleaser.yml                                  error=configuration is valid, but uses deprecated properties
  ⨯ command failed                                   error=1 out of 1 configuration file(s) have https://black.readthedocs.io/en/stable/integrations/source_version_control.html
```

We have to provide this
[`--soft`](https://goreleaser.com/cmd/goreleaser_check/?h=check#see-also) flag to the `check` command:

```console
  $ goreleaser check --soft
  • by using this software you agree with its EULA, available at https://goreleaser.com/eula
  • running goreleaser v2.7.0
  • checking                                 path=.goreleaser.yml
  • DEPRECATED:  snapshot.name_template  should not be used anymore, check https://goreleaser.com/deprecations#snapshotname_template for more info
  • DEPRECATED:  archives.format_overrides.format  should not be used anymore, check https://goreleaser.com/deprecations#archivesformat_overridesformat for more info
  • .goreleaser.yml                                  error=configuration is valid, but uses deprecated properties
  • 1 configuration file(s) validated
  • thanks for using GoReleaser Pro!
  ```
kwk added 4 commits March 6, 2025 13:55
This fixes these issues:

```
  • DEPRECATED:  snapshot.name_template  should not be used anymore, check https://goreleaser.com/deprecations#snapshotname_template for more info
  • DEPRECATED:  archives.format_overrides.format  should not be used anymore, check https://goreleaser.com/deprecations#archivesformat_overridesformat for more info
```
@kwk kwk changed the title Fix #427 Fix goreleaser: Upgrade to v2 format and command line flag migration Mar 6, 2025
@ejoffe
Copy link
Owner

ejoffe commented Mar 10, 2025

Sorry about the long delay.
Thank you for bringing this version up to date.

@ejoffe ejoffe merged commit 05f3c06 into ejoffe:master Mar 10, 2025
1 check passed
@kwk
Copy link
Contributor Author

kwk commented Mar 11, 2025

Sorry about the long delay. Thank you for bringing this version up to date.

@ejoffe no worries and thank YOU for accepting PRs. I'm super happy to see that the repository/project isn't abandoned. The last commit to master was in August and I wasn't sure if this is still being worked on. Btw. I noticed that you didn't squash my commits. I'm sorry that we now have all these small commits littering master.

@ejoffe
Copy link
Owner

ejoffe commented Mar 11, 2025

Meh, I didn't notice it, to used to spr commit stacks. We'll live with the ugly commits.

@ejoffe
Copy link
Owner

ejoffe commented Mar 13, 2025

Released in v0.15.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't run make bin with goreleaser 2.3.2 and --skip-publish
2 participants