Skip to content

Implement last filter #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 17, 2018
Merged

Implement last filter #43

merged 2 commits into from
Nov 17, 2018

Conversation

jbszczepaniak
Copy link
Contributor

Fixes #42

Along with feature I refactored querySelectorsToQuery to use intermediate function stringToTime which deals with before and after, if however last filter is used - before and after are ignored, and lastToTimeInterval handles conversion of filter.

@jbszczepaniak jbszczepaniak merged commit e2c7eb9 into egnyte:master Nov 17, 2018
@jbszczepaniak jbszczepaniak mentioned this pull request Nov 17, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@gethiox gethiox gethiox approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jbszczepaniak @gethiox