Skip to content

Conversation

fengmk2
Copy link
Member

@fengmk2 fengmk2 commented Mar 4, 2017

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

@mention-bot
Copy link

@fengmk2, thanks for your PR! By analyzing the history of the files in this pull request, we identified @dead-horse, @popomore and @atian25 to be potential reviewers.

@fengmk2 fengmk2 requested a review from popomore March 4, 2017 17:45
@popomore
Copy link
Member

popomore commented Mar 8, 2017

win 的测试挂了, @dead-horse 原来就这样?

@popomore
Copy link
Member

@dead-horse 看看

@dead-horse
Copy link
Member

@popomore 恩,我先合掉再修复一下

@dead-horse dead-horse merged commit 329b7f7 into master Apr 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants