Skip to content

Fix/from node #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 29, 2021
Merged

Fix/from node #74

merged 3 commits into from
Dec 29, 2021

Conversation

philipp-kunz-mimacom
Copy link

the idea for this pull request occurred to me when i desperately tried to run the test locally which did not work due to an already locally present but outdated node image.

just now, dependabot will create a mr to update node from 16 to 17 as demonstrated in https://github.com/philipp-kunz-mimacom/wait-for/pull/1/files

Addono
Addono suggested changes Dec 13, 2021
View reviewed changes
Copy link

@Addono Addono left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! Thanks for another PR. I'm up for pinning the Docker SHA if Node-latest is causing issues.

I have one comment on the Dependabot configuration, since I rather not bump the image label to 17 on it's first PR. Once that's fixed we're good to go.

@philipp-kunz-mimacom philipp-kunz-mimacom mentioned this pull request Dec 13, 2021
Closed
@Addono
Copy link

Addono commented Dec 13, 2021

I will wait a bit to see if the Dependabot config works before merging it in 😇

Might take a while, since it will only trigger when there's a newer version of node:16-alpine available.

@Addono Addono self-requested a review December 13, 2021 09:57
Addono
Addono approved these changes Dec 29, 2021
View reviewed changes
Copy link

@Addono Addono left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for hanging on, I see that Dependabot opened philipp-kunz-mimacom#2, which means that the range-filter works fine (and in doing so defied my expectations, kudos for Dependabot 😄 ).

LGTM 🚀 and let's merge!

@Addono Addono merged commit a9b8f89 into eficode:master Dec 29, 2021
@Addono
Copy link

Addono commented Dec 29, 2021

@philipp-kunz-mimacom looking at what you have in your fork's master branch, I presume we also need philipp-kunz-mimacom@45627e6 to get Dependabot to start triggering, right?

@philipp-kunz-mimacom
Copy link
Author

@philipp-kunz-mimacom looking at what you have in your fork's master branch, I presume we also need philipp-kunz-mimacom@45627e6 to get Dependabot to start triggering, right?

i don't think so. far as i remember that was a test to trigger dependabot. i guess it would not make a difference really except for the tag including a minor number or not but either way would point to the same image anyway.

@philipp-kunz-mimacom philipp-kunz-mimacom deleted the fix/from-node branch January 3, 2022 07:45
@github-actions
Copy link

🎉 This PR is included in version 2.2.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@Addono Addono Addono approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@philipp-kunz-mimacom @Addono