fix(test): support running our test suite under -trimpath, closes #397
#439
Conversation
|
it build fine with my PKGBUILD after updating _commit variable to f57718a on my machine |
There was a problem hiding this comment.
Great! 😄
To clarify, does that mean that now editorconfig-checker can be compiled both with and without the -trimpath option? If we don't compile with -trimpath, it works too right?
Should we release a v3.2.1, as soon, as this is merged, to unblock Alpine Linux and other distributions?
It will work with both with and without
Definitely. |
13e765e to
e202831
Compare
This commit is guaranteed to be broken, since our code not yet handles the caveats regarding the current working dir assumption that go-snaps now has.
…ch test phase fails
…lute path Since we "tamper" with the current working directory to achieve a certain output from files.GetRelativePath(), we now need to help snaps find the __snapshots__ directory.
|
@mstruebing could I bother you for the final review? |
Thanks for @gkampitakis we can now support running the editorconfig-checker test suite with
-trimpath.