Swift 5 examples #33
Merged
Swift 5 examples #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RomanPodymov
commented
May 22, 2019
| @@ -14,7 +14,7 @@ class ViewController: NSViewController { | |||
| fileprivate let attributedStrings: [NSAttributedString] = [ | |||
| { | |||
| let attachment = TextAttachment() | |||
| attachment.image = NSImage(named: "Star")! | |||
There was a problem hiding this comment.
The app is getting crash on this line because there is no such image. That's why I removed !.
RomanPodymov
commented
May 22, 2019
| @@ -84,6 +84,11 @@ | |||
| "idiom" : "ipad", | |||
| "size" : "83.5x83.5", | |||
| "scale" : "2x" | |||
| }, | |||
| { | |||
| "idiom" : "ios-marketing", | |||
There was a problem hiding this comment.
Generated by Xcode.
eddiekaiger
approved these changes
May 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello.
As I can see there are 2 languages that are using in this project - Swift 5 and Swift 3. In this pull request I set Swift 5 for all targets and fixed build errors.