Use node 22 for remote containers #15937
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is needed because otherwise executing something on the container will fail. Also make sure to report the error channel instead of the stdout channel if starting the container fails. This will require a recompiling of the native dependencies. Signed-off-by: Simon Graband <sgraband@eclipsesource.com>
ndoschek
approved these changes
Jul 2, 2025
There was a problem hiding this comment.
Thanks @sgraband for this fix!
I tested the glsp-website-source repository to open in the Dev Container and it works again as expected! 👍
rschnekenbu
approved these changes
Jul 2, 2025
There was a problem hiding this comment.
LGTM! I only looked at the code, feature was tested by @ndoschek
sgraband
added a commit
that referenced
this pull request
Jul 7, 2025
This is needed because otherwise executing something on the container will fail. Also make sure to report the error channel instead of the stdout channel if starting the container fails. This will require a recompiling of the native dependencies. Signed-off-by: Simon Graband <sgraband@eclipsesource.com>
laemmleint
pushed a commit
to mvtecsoftware/theia
that referenced
this pull request
Aug 18, 2025
This is needed because otherwise executing something on the container will fail. Also make sure to report the error channel instead of the stdout channel if starting the container fails. This will require a recompiling of the native dependencies. Signed-off-by: Simon Graband <sgraband@eclipsesource.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
This is needed because otherwise executing something on the container will fail. Also make sure to report the error channel instead of the stdout channel if starting the container fails. This will require a recompiling of the native dependencies.
How to test
On master, starting a devcontainer will not work and fail with
Could not start remote system:.Follow-ups
Breaking changes
Attribution
Review checklist
Reminder for reviewers