Add functions for launch configuration #15941
Conversation
3841899 to
ebe0b48
Compare
There was a problem hiding this comment.
Thank you @eneufeld, this is an awesome improvement! 🚀
I tested the AppTester quite a bit, and using the new functions is a pleasure.
I noticed that it sometimes fails to stop the launch configurations when it starts the application with a compound launch configuration (e.g., "Launch Browser Backend & Frontend"; see the screenshot below).
If the instructions are more specific than in my example, it worked as expected everytime. I'm not sure whether we can do anything about this, but I wanted to mention it here.
Screenshot
Besides that, as I mentioned in your other PR, I noticed quite a few changes that are essentially only code formatting. If you find the time, could you revert those? Thanks in advance! TIA
There was a problem hiding this comment.
Especially in this file it is hard to get the actual changes due to the many formatting changes.
6379dd0 to
b1a1a95
Compare
|
@ndoschek updated the formatting |
There was a problem hiding this comment.
Thanks @eneufeld, LGTM just a few nitpicks, but besides that I think we are good to go.
@sdirix Could you please also have a quick look too, as we need an approval from a committer, thanks!
Regarding my earlier comment about the compound configurations:
Do you think this could be solved? If so, we could also consider opening a follow-up.
|
|
||
| await this.debugConfigurationManager.load(); | ||
|
|
||
| // Find the configuration by name |
There was a problem hiding this comment.
nit
| // Find the configuration by name |
| return `Did not find a launch configuration for the name: '${args.configurationName}'`; | ||
| } | ||
|
|
||
| // Start the debug session |
There was a problem hiding this comment.
nit
| // Start the debug session |
| return `Failed to start launch configuration '${args.configurationName}'`; | ||
| } | ||
|
|
||
| // Handle cancellation |
There was a problem hiding this comment.
nit
| // Handle cancellation |
| export const LIST_LAUNCH_CONFIGURATIONS_FUNCTION_ID = | ||
| 'listLaunchConfigurations'; |
There was a problem hiding this comment.
nit
| export const LIST_LAUNCH_CONFIGURATIONS_FUNCTION_ID = | |
| 'listLaunchConfigurations'; | |
| export const LIST_LAUNCH_CONFIGURATIONS_FUNCTION_ID = 'listLaunchConfigurations'; |
- add "listLaunchConfigurations" - add "runLaunchConfiguration" - add "stopLaunchConfiguration" This allows to start and stop existing run configurations. - Also removed a circular dependency by duplicating label resolution
b1a1a95 to
e3c398c
Compare
|
@sdirix As Nina is on vacation, could you have a final look? |
There was a problem hiding this comment.
Works for me!
Follow up work: Via these functions the LLM is not provided information about which configurations are currently running, it assumes this from history alone which is not sufficient if the user manually started/stopped configurations. Please create a ticket for this.
|
Created follow-up: #16065 |
What it does
This allows to start and stop existing run configurations.
How to test
Start the app, use AppTester Agent and provide it the three functions.
Ask it to start an application , do something in the app and then stop it.
Follow-ups
Breaking changes
Attribution
Review checklist
Reminder for reviewers