fix:IDE cannot fully restore to the previous state after restarting. #15898
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
reopen from #15890 |
tsmaeder
approved these changes
Jul 8, 2025
laemmleint
pushed a commit
to mvtecsoftware/theia
that referenced
this pull request
Aug 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Fixes #15201
I think that the previous modification set the model to null after the editor was hidden, so nothing would be done in editor.saveViewState(). However, savedViewState was set when the editor was hidden, so we only need to read this value.So I modified the storeViewState and restoreViewState functions in monaco-editor
How to test
1.I compiled theia-ide application locally, and it was verified that this is effective and can solve the problem #15201
2.For example, the gif image operation in #15201 will get the expected result
Follow-ups
Breaking changes
Attribution
Review checklist
Reminder for reviewers