fix store view ,fix #15201 #15890
fix store view ,fix #15201 #15890
Conversation
|
Hi @zhangzejun123, thanks for the PR, but we technically cannot merge any PR's if they don't pass the ECA check. Could you sign the contributor agreement (https://www.eclipse.org/legal/eca/), please? Also: you make our life significantly simpler if you fill out the PR template that is displayed when opening a PR: just simply seeing what you're trying to achieve and how you tested the change makes us faster in reviewing PR's and there are currently a lot of open PR's. |
I am very sorry, this is my first time submitting a PR here. The ECA check has passed. Do I need to submit a PR again? |
No need to be sorry, we like to have newcomers on the project and no need to re-submit the PR. Thanks. |
|
I found that if you open theia-ide and close it without doing anything, savedViewState will store an empty value, so I added a modification to store savedViewState when restoringViewState. Please review this pr again |
|
This PR looks a bit messy, I'll start a new one |
I think that the previous modification set the model to null after the editor was hidden, so nothing would be done in editor.saveViewState(). However, savedViewState was set when the editor was hidden, so we only need to read this value. Do you think this is okay?