Skip to content

Refine inline Ask AI chat input appearance #15885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 26, 2025
Merged

Refine inline Ask AI chat input appearance #15885

merged 2 commits into from
Jun 26, 2025

Conversation

ndoschek
Copy link
Contributor

What it does

  • Align styling to match the chat input in the main chat view, ensuring consistent appearance
  • Do not show top arrow for a cleaner UI
  • Adjust the zone widget layout dynamically based on the chat input height
  • Display pinned agents to allow agent selection in the inline input

How to test

  • Open the Ask AI inline chat widget and observe that the styling matches the chat input in the AI Chat View
  • Observe that the editor zone widget is more in line with other of that kind, like the git inline quick diff or the conditional breakpoint editing
  • If multiple lines are entered, the editor zone widget grows dynamically

Follow-ups

x

Breaking changes

  • This PR introduces breaking changes and requires careful review. If yes, the breaking changes section in the changelog has been updated.

Attribution

Review checklist

Reminder for reviewers

@ndoschek
Refine inline Ask AI chat input appearance
57a719d 
- Align styling to match the chat input in the main chat view, ensuring consistent appearance
- Do not show top arrow for a cleaner UI
- Adjust the zone widget layout dynamically based on the chat input height
- Display pinned agents to allow agent selection in the inline input
@github-project-automation github-project-automation bot moved this to Waiting on reviewers in PR Backlog Jun 25, 2025
@ndoschek ndoschek requested a review from JonasHelming June 25, 2025 11:40
@ndoschek ndoschek mentioned this pull request Jun 24, 2025
Closed
61 tasks
@rschnekenbu rschnekenbu self-requested a review June 25, 2025 12:37
rschnekenbu
rschnekenbu requested changes Jun 26, 2025
View reviewed changes
Copy link
Contributor

@rschnekenbu rschnekenbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good in general except my comment on emitter.
Behavior is also good (tested on electron), changing theme, font size, zoom, etc.

@github-project-automation github-project-automation bot moved this from Waiting on reviewers to Waiting on author in PR Backlog Jun 26, 2025
@ndoschek
address review comment
bfe2241 
- add onResize emitter to toDispose collection
@ndoschek ndoschek requested a review from rschnekenbu June 26, 2025 07:57
@rschnekenbu
Copy link
Contributor

@ndoschek , that was a quick fix 👍 I retriggered the failed license check, but that should not be a problem for this PR. No change in dependencies was pushed.

rschnekenbu
rschnekenbu approved these changes Jun 26, 2025
View reviewed changes
Copy link
Contributor

@rschnekenbu rschnekenbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-project-automation github-project-automation bot moved this from Waiting on author to Needs merge in PR Backlog Jun 26, 2025
@rschnekenbu rschnekenbu merged commit d324208 into eclipse-theia:master Jun 26, 2025
10 of 12 checks passed
@github-project-automation github-project-automation bot moved this from Needs merge to Done in PR Backlog Jun 26, 2025
@github-actions github-actions bot added this to the 1.63.0 milestone Jun 26, 2025
@ndoschek ndoschek deleted the refine-ask-ai-appearance branch June 26, 2025 08:18
laemmleint pushed a commit to mvtecsoftware/theia that referenced this pull request Aug 18, 2025
@ndoschek @laemmleint
Refine inline Ask AI chat input appearance (eclipse-theia#15885)
681f731 
- Align styling to match the chat input in the main chat view, ensuring consistent appearance
- Do not show top arrow for a cleaner UI
- Adjust the zone widget layout dynamically based on the chat input height
- Display pinned agents to allow agent selection in the inline input
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rschnekenbu rschnekenbu rschnekenbu approved these changes

@JonasHelming JonasHelming Awaiting requested review from JonasHelming

Assignees
No one assigned
Labels
None yet
Projects
PR Backlog
Archived in project
Milestone
1.63.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ndoschek @rschnekenbu