Remove requirement that agent has to be mentioned first #15854
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From my testing and looking at the code this does not have any side effect. Fixes #15272 Signed-off-by: Simon Graband <sgraband@eclipsesource.com>
|
IIRC, variable resolving was dependent on agents at some point, so that would be an explanation on why this was coded this way. However I would definitely prefer if we are able to mention the agent wherever. |
sdirix
approved these changes
Jun 24, 2025
laemmleint
pushed a commit
to mvtecsoftware/theia
that referenced
this pull request
Aug 18, 2025
…e-theia#15854) Fixes eclipse-theia#15272 Signed-off-by: Simon Graband <sgraband@eclipsesource.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
From my testing and looking at the code this does not have any side effects. @sdirix do you have an idea why we originally added this? Or was this an oversight?
Fixes #15272
How to test
Write something like
#_f @Coderin the chat and see that the Agent is correctly set.Follow-ups
Breaking changes
Attribution
Review checklist
Reminder for reviewers