Add a new tools which allow to list and run tasks #15504

eneufeld · 2025-04-23T07:23:46Z

What it does

fixes #15503

How to test

Follow-ups

Breaking changes

This PR introduces breaking changes and requires careful review. If yes, the breaking changes section in the changelog has been updated.

Attribution

Review checklist

As an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

As a reviewer, I agree to behave in accordance with the review guidelines

Copilot

Pull Request Overview

This PR introduces new tool providers to enhance the IDE's functionality by allowing users to list, run, and search tasks within the workspace. Key changes include:

Adding TaskListProvider for filtering and listing available tasks.
Implementing TaskRunnerProvider for executing specified tasks.
Creating WorkspaceSearchProvider for searching file content, with updated module bindings.

Reviewed Changes

Copilot reviewed 4 out of 6 changed files in this pull request and generated 2 comments.

File	Description
packages/ai-ide/src/browser/workspace-task-provider.ts	Adds TaskListProvider and TaskRunnerProvider for task management.
packages/ai-ide/src/browser/workspace-search-provider.ts	Adds WorkspaceSearchProvider for content search in the workspace.
packages/ai-ide/src/browser/frontend-module.ts	Updates bindings to include the new providers.

Files not reviewed (2)

packages/ai-ide/package.json: Language not supported
packages/ai-ide/tsconfig.json: Language not supported

Copilot · 2025-04-23T07:24:51Z

packages/ai-ide/src/browser/workspace-task-provider.ts

+            cancellationToken.onCancellationRequested(() => {
+                this.taskService.terminateTask(taskInfo);
+            });
+            const terminal = this.terminalService.getByTerminalId(taskInfo.terminalId!);


Ensure cancellationToken is defined before invoking onCancellationRequested; consider making the cancellationToken parameter optional or adding a null check to prevent potential runtime errors.

Suggested change

cancellationToken.onCancellationRequested(() => {

this.taskService.terminateTask(taskInfo);

});

const terminal = this.terminalService.getByTerminalId(taskInfo.terminalId!);

if (cancellationToken) {

cancellationToken.onCancellationRequested(() => {

this.taskService.terminateTask(taskInfo);

});

}

Copilot · 2025-04-23T07:24:51Z

packages/ai-ide/src/browser/workspace-task-provider.ts

+            cancellationToken.onCancellationRequested(() => {
+                this.taskService.terminateTask(taskInfo);
+            });
+            const terminal = this.terminalService.getByTerminalId(taskInfo.terminalId!);


Avoid using a non-null assertion on taskInfo.terminalId; verify its existence before retrieving the terminal to prevent potential runtime errors.

Suggested change

const terminal = this.terminalService.getByTerminalId(taskInfo.terminalId!);

if (!taskInfo.terminalId) {

return `Task '${args.taskName}' does not have an associated terminal.`;

}

const terminal = this.terminalService.getByTerminalId(taskInfo.terminalId);

Copilot

Pull Request Overview

This PR adds new tools for managing tasks and searching the workspace.

Introduces TaskListProvider and TaskRunnerProvider to list and run tasks.
Implements WorkspaceSearchProvider for file content search.
Registers the new providers in the frontend module.

Reviewed Changes

Copilot reviewed 4 out of 6 changed files in this pull request and generated 2 comments.

File	Description
packages/ai-ide/src/browser/workspace-task-provider.ts	Implements task listing and execution tools.
packages/ai-ide/src/browser/workspace-search-provider.ts	Adds workspace search functionality.
packages/ai-ide/src/browser/frontend-module.ts	Registers new tool providers with the frontend module.

Files not reviewed (2)

packages/ai-ide/package.json: Language not supported
packages/ai-ide/tsconfig.json: Language not supported

Copilot · 2025-04-23T09:22:56Z

packages/ai-ide/src/browser/workspace-task-provider.ts

+                const allLines = terminal?.buffer.getLines(0, length).reverse() ?? [];
+
+                // collect the first 50 lines:
+                const firstLines = allLines.slice(0, numberOfLines);
+                result.push(...firstLines);
+                // collect the last 50 lines:
+                if (length > numberOfLines) {
+                    const lastLines = allLines.slice(length - numberOfLines);


The logic for retrieving terminal output lines may lead to overlapping or unexpected results when slicing for the first and last 50 lines due to the use of reverse before slicing. Consider revising the approach to capture these segments from the original order separately.

Suggested change

const allLines = terminal?.buffer.getLines(0, length).reverse() ?? [];

// collect the first 50 lines:

const firstLines = allLines.slice(0, numberOfLines);

result.push(...firstLines);

// collect the last 50 lines:

if (length > numberOfLines) {

const lastLines = allLines.slice(length - numberOfLines);

const allLines = terminal?.buffer.getLines(0, length) ?? [];

// collect the first 50 lines:

const firstLines = allLines.slice(0, numberOfLines);

result.push(...firstLines);

// collect the last 50 lines:

if (length > numberOfLines) {

const lastLines = allLines.slice(-numberOfLines);

Copilot · 2025-04-23T09:22:57Z

packages/ai-ide/src/browser/workspace-task-provider.ts

+            return `No terminal output available. The terminate signal was :${signal}.`;
+
+        } catch (error) {
+            return JSON.stringify({ success: false, message: error.message || 'Failed to run task' });


Error handling assumes that the thrown 'error' object has a 'message' property, which might not always be true. Consider adding a type check or providing a default error value that safely handles non-Error objects.

Suggested change

return JSON.stringify({ success: false, message: error.message || 'Failed to run task' });

const errorMessage = error instanceof Error && error.message

? error.message

: typeof error === 'string'

? error

: JSON.stringify(error) || 'Failed to run task';

return JSON.stringify({ success: false, message: errorMessage });

planger · 2025-04-24T12:44:51Z

packages/ai-ide/src/browser/workspace-task-provider.ts

+            description: 'Lists available tasks filtered by name.',
+            parameters: {
+                type: 'object',
+                properties: {


I'm wondering whether the filtering by name really adds value. Usually projects have less than 30 tasks, which should be fine to always return.

planger

I took the liberty to directly make some changes.
I had issues as the list of tasks we provide to the LLM wasn't the same as we used for retrieving the command to execute. Also the search should be case-insensitive.

This change is now fine with me and works great!

planger · 2025-04-25T12:29:38Z

packages/ai-ide/src/common/coder-replace-prompt-template.ts

+To locate a file within the workspace, use the ~{searchInWorkspace} feature.
+
+## Tasks
+
+The user might want you to execute some task. You can find tasks using ~{listTasks} and execute them using ~{runTask}.


Shouldn't we use the constants to refer to the tool functions?

packages/ai-ide/src/common/coder-replace-prompt-template.ts

JonasHelming

LGTM, just one wording suggestion

fixes #15467

fixes #15503

Co-authored-by: Jonas Helming <jhelming@eclipsesource.com>

eneufeld requested review from planger, JonasHelming and Copilot April 23, 2025 07:23

github-project-automation bot added this to PR Backlog Apr 23, 2025

github-project-automation bot moved this to Waiting on reviewers in PR Backlog Apr 23, 2025

Copilot AI reviewed Apr 23, 2025

View reviewed changes

eneufeld requested a review from Copilot April 23, 2025 09:22

Copilot AI reviewed Apr 23, 2025

View reviewed changes

JonasHelming mentioned this pull request Apr 23, 2025

Endgame Plan for release 1.61 #15494

Closed

13 tasks

planger reviewed Apr 24, 2025

View reviewed changes

planger self-requested a review April 24, 2025 13:01

planger approved these changes Apr 24, 2025

View reviewed changes

github-project-automation bot moved this from Waiting on reviewers to Needs merge in PR Backlog Apr 24, 2025

planger mentioned this pull request Apr 24, 2025

Add support for search in workspace #15493

Closed

2 tasks

eneufeld force-pushed the gh-15503 branch 2 times, most recently from 98e2f5b to 7186042 Compare April 25, 2025 10:51

planger approved these changes Apr 25, 2025

View reviewed changes

eneufeld force-pushed the gh-15503 branch from 7186042 to 6d25219 Compare April 25, 2025 12:42

planger approved these changes Apr 25, 2025

View reviewed changes

JonasHelming reviewed Apr 25, 2025

View reviewed changes

packages/ai-ide/src/common/coder-replace-prompt-template.ts Outdated Show resolved Hide resolved

JonasHelming approved these changes Apr 25, 2025

View reviewed changes

eneufeld and others added 3 commits April 25, 2025 17:50

Add support for search in workspace

40ebdbb

fixes #15467

Add a new tools which allow to list and run tasks

50f8962

fixes #15503

Add next template for coder

95b9490

Co-authored-by: Jonas Helming <jhelming@eclipsesource.com>

eneufeld force-pushed the gh-15503 branch from 0dc9df1 to 95b9490 Compare April 25, 2025 15:50

eneufeld merged commit 620d284 into master Apr 25, 2025
9 of 11 checks passed

github-project-automation bot moved this from Needs merge to Done in PR Backlog Apr 25, 2025

github-actions bot added this to the 1.61.0 milestone Apr 25, 2025

This was referenced May 1, 2025

AppTester Agent via Browser Automation eclipsesource/theia#196

Closed

AppTester Agent with DOM Access eclipsesource/theia#206

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add a new tools which allow to list and run tasks #15504

Add a new tools which allow to list and run tasks #15504

Uh oh!

eneufeld commented Apr 23, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Apr 23, 2025

Uh oh!

Copilot AI Apr 23, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Apr 23, 2025

Uh oh!

Copilot AI Apr 23, 2025

Uh oh!

planger Apr 24, 2025

Uh oh!

planger left a comment

Uh oh!

planger Apr 25, 2025

Uh oh!

Uh oh!

JonasHelming left a comment

Uh oh!

Uh oh!

Uh oh!

-            const terminal = this.terminalService.getByTerminalId(taskInfo.terminalId!);
+            if (!taskInfo.terminalId) {
+                return `Task '${args.taskName}' does not have an associated terminal.`;
+            }
+            const terminal = this.terminalService.getByTerminalId(taskInfo.terminalId);

-            return JSON.stringify({ success: false, message: error.message || 'Failed to run task' });
+            const errorMessage = error instanceof Error && error.message
+                ? error.message
+                : typeof error === 'string'
+                    ? error
+                    : JSON.stringify(error) || 'Failed to run task';
+            return JSON.stringify({ success: false, message: errorMessage });

Add a new tools which allow to list and run tasks #15504

Add a new tools which allow to list and run tasks #15504

Uh oh!

Conversation

eneufeld commented Apr 23, 2025

What it does

How to test

Follow-ups

Breaking changes

Attribution

Review checklist

Reminder for reviewers

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Apr 23, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 23, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Apr 23, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 23, 2025

Choose a reason for hiding this comment

Uh oh!

planger Apr 24, 2025

Choose a reason for hiding this comment

Uh oh!

planger left a comment

Choose a reason for hiding this comment

Uh oh!

planger Apr 25, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

JonasHelming left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!