Add support for search in workspace #15493
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
planger
approved these changes
Apr 22, 2025
| }, | ||
| required: ['query', 'useRegExp'] | ||
| }, | ||
| handler: (argString: string) => this.handleSearch(argString) |
There was a problem hiding this comment.
It might be worth looking for a cancellation token to ensure long running searches can be canceled by the user if the user cancels the response:
handler: async (args: string, ctx?: MutableChatRequestModel): Promise<string> => {
const token = ctx?.response?.cancellationToken;
...| return { | ||
| id: SEARCH_IN_WORKSPACE_ID, | ||
| name: SEARCH_IN_WORKSPACE_ID, | ||
| description: 'Searches the workspace for files containing the provided query string or regular expression.', |
There was a problem hiding this comment.
I had a few cases where the AI tried to search for multi-word search strings. So we should probably guide the AI here a bit better how to use this search tool. Maybe the following works better?
Suggested change
| description: 'Searches the workspace for files containing the provided query string or regular expression.', | |
| description: 'Searches the workspace for files matching the given search term (parameter `query`), using case-insensitive full-string or regex matching. Multi-word patterns must match exactly (including spaces, but case-insensitive). For best results, prefer multiple queries with alternative search terms, over single long or complex ones.', |
But I didn't deeply test this.
13 tasks
JonasHelming
approved these changes
Apr 23, 2025
planger
approved these changes
Apr 24, 2025
| }; | ||
| } | ||
|
|
||
| private async handleSearch(argString: string, cancellationToken: CancellationToken): Promise<string> { |
There was a problem hiding this comment.
Suggested change
| private async handleSearch(argString: string, cancellationToken: CancellationToken): Promise<string> { | |
| private async handleSearch(argString: string, cancellationToken?: CancellationToken): Promise<string> { |
| this.searchService.search(args.query, callbacks, options) | ||
| .then(id => { | ||
| expectedSearchId = id; | ||
| cancellationToken.onCancellationRequested(() => { |
There was a problem hiding this comment.
Suggested change
| cancellationToken.onCancellationRequested(() => { | |
| cancellationToken?.onCancellationRequested(() => { |
|
fixed as part of #15504 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
fixes #15467
How to test
Follow-ups
Breaking changes
Attribution
Review checklist
Reminder for reviewers