Add schema for agent settings #15175
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdirix
approved these changes
Mar 13, 2025
Co-authored-by: Stefan Dirix <sdirix@eclipsesource.com>
I believe that that isn't a consequence of how this preference is declared, but of this bug: |
|
@colin-grant-work good catch. When adapting the |
2 tasks
laemmleint
pushed a commit
to mvtecsoftware/theia
that referenced
this pull request
Aug 18, 2025
Fixes eclipse-theia#15174 Co-authored-by: Stefan Dirix <sdirix@eclipsesource.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed #15174
What it does
registers a schema for the agent settings
How to test
Open the settings.json and see that agent settings do not show a warning anymore
Follow-ups
Breaking changes
Attribution
Review checklist
Reminder for reviewers