Skip to content

Conversation

msujew
Copy link
Member

@msujew msujew commented Mar 6, 2025

What it does

Closes #15093

Prevents the issue from appearing by no longer using a regex at all.

How to test

See reproduction steps of #15093.

Review checklist

Reminder for reviewers

@msujew msujew added the localization issues related to localization/internalization/nls label Mar 6, 2025
@github-project-automation github-project-automation bot moved this to Waiting on reviewers in PR Backlog Mar 6, 2025
@JonasHelming JonasHelming requested a review from sdirix March 18, 2025 18:21
Copy link
Member

@sdirix sdirix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested with the MarsCode AI extension and the fix worked for me.

Good work! I also like the simplification, always good to get rid of regexes where not needed. 🎉

@github-project-automation github-project-automation bot moved this from Waiting on reviewers to Needs merge in PR Backlog Mar 18, 2025
@msujew msujew merged commit f82aba4 into master Mar 19, 2025
10 of 11 checks passed
@github-project-automation github-project-automation bot moved this from Needs merge to Done in PR Backlog Mar 19, 2025
@msujew msujew deleted the msujew/fix-plugin-package-localization branch March 19, 2025 13:42
@github-actions github-actions bot added this to the 1.60.0 milestone Mar 19, 2025
@msujew msujew mentioned this pull request Mar 24, 2025
1 task
laemmleint pushed a commit to mvtecsoftware/theia that referenced this pull request Aug 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
localization issues related to localization/internalization/nls
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Incorrect translation of marscode ai plugin: Regular expression does not support keys containing spaces
2 participants