[vscode] make public the documentPaste proposed API #14953
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d9ed76f to
cc56869
Compare
fixes #14938 Contributed on behalf of STMicroelectronics Signed-off-by: Remi Schnekenburger <rschnekenburger@eclipsesource.com>
cc56869 to
55461d2
Compare
tsmaeder
approved these changes
Feb 26, 2025
laemmleint
pushed a commit
to mvtecsoftware/theia
that referenced
this pull request
Aug 18, 2025
) fixes eclipse-theia#14938 Contributed on behalf of STMicroelectronics Signed-off-by: Remi Schnekenburger <rschnekenburger@eclipsesource.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
The proposed API theia.proposed.documentPaste.d.ts is now public and must be moved to theia.d.ts. It was previously stub. This PR currently only makes the API public, but it is still stubbed. It will be implemented or pushed as current state dependening on time available to implement.
fixes #14938
How to test
Not much to test here, as the API was already implemented or stub previously.
The API was adopted without changes.
One note about API however: registerDocumentDropEditProvider has now an optional metadata parameter, that was already implemented (see
theia/packages/plugin-ext/src/plugin/plugin-context.ts
Line 1054 in 9a20727
I provided a sample extension that register a DocumentPasteEditProvider. It should start without complaining, as the API is stubbed.
src:
document-paste-sample-0.0.1-src.zip
zipped vsix:
document-paste-sample-0.0.1.zip
Follow-ups
Implement stubbed API: #15058
Breaking changes
Attribution
Contributed on behalf of STMicroelectronics
Review checklist
Reminder for reviewers