deps: Bump fix-path to ^4.0.0 to avoid cross-env <6.0.6 #14781
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cross-env 6.0.6 fixes CVE-2024-21538 (https://security.snyk.io/vuln/SNYK-JS-CROSSSPAWN-8303230). Contributed by STMicroelectronics Signed-off-by: Torbjörn SVENSSON <torbjorn.svensson@foss.st.com>
rschnekenbu
approved these changes
Jan 29, 2025
marcdumais-work
added a commit
to eclipse-cdt-cloud/theia-trace-extension
that referenced
this pull request
Apr 8, 2025
Issue encountered: eclipse-theia/theia#14804 Another PR updated "fix-path" and caused the issue: eclipse-theia/theia#14781 A fix was done: eclipse-theia/theia#14812 Side-effect of the fix: eclipse-theia/theia#14804 (comment) Fix to address the side-effect: eclipse-theia/theia#14819 Note: the fix for the side-effect was merged on Theia master, and does not help momentariry on the community release 1.58.x, on which it's not currently planned to back-port this fix: eclipse-theia/theia#14819 (comment) We could contribute a PR to back-port the fix, but I do not think this is super important for us - the Theia Electron app is only an example application and permanently switching to a bundled Electron backend does not seem to have any downside. In consequence, this PR includes using the bundled Electron backend, which is a simple webpack config update. If we later notice issues with this, we can roll-back to use the non-bundled backend in the next community release, which will have the fix above. Note about the webpack config update: as suggested, I have deleted the webpack configs and run "theia build" to have them re-created. Then I re-added the small change we need for the time range context menu. The result is a webpack config that's more aligned with the one Theia generates, for both our example Theia apps. Signed-off-by: Marc Dumais <marc.dumais@ericsson.com>
marcdumais-work
added a commit
to eclipse-cdt-cloud/theia-trace-extension
that referenced
this pull request
Apr 8, 2025
Issue encountered: eclipse-theia/theia#14804 A PR updated "fix-path" and caused the issue: eclipse-theia/theia#14781 A fix was done: eclipse-theia/theia#14812 Side-effect of the fix: eclipse-theia/theia#14804 (comment) Fix to address the side-effect: eclipse-theia/theia#14819 Note: the fix for the side-effect was merged on Theia master, and does not help momentariry on the community release 1.58.x, on which it's not currently planned to back-port this fix: eclipse-theia/theia#14819 (comment) We could contribute a PR to back-port the fix, but I do not think this is super important for us - the Theia Electron app is only an example application and permanently switching to a bundled Electron backend does not seem to have any downside. In consequence, this PR includes using the bundled Electron backend, which is a simple webpack config update. If we later notice issues with this, we can roll-back to use the non-bundled backend in the next community release, which will have the fix above. Note about the webpack config update: as suggested, I have deleted the webpack configs and run "theia build" to have them re-created. Then I re-added the small change we need for the time range context menu. The result is a webpack config that's more aligned with the one Theia generates, for both our example Theia apps. Signed-off-by: Marc Dumais <marc.dumais@ericsson.com>
marcdumais-work
added a commit
to eclipse-cdt-cloud/theia-trace-extension
that referenced
this pull request
Apr 14, 2025
Issue encountered: eclipse-theia/theia#14804 A PR updated "fix-path" and caused the issue: eclipse-theia/theia#14781 A fix was done: eclipse-theia/theia#14812 Side-effect of the fix: eclipse-theia/theia#14804 (comment) Fix to address the side-effect: eclipse-theia/theia#14819 Note: the fix for the side-effect was merged on Theia master, and does not help momentariry on the community release 1.58.x, on which it's not currently planned to back-port this fix: eclipse-theia/theia#14819 (comment) We could contribute a PR to back-port the fix, but I do not think this is super important for us - the Theia Electron app is only an example application and permanently switching to a bundled Electron backend does not seem to have any downside. In consequence, this PR includes using the bundled Electron backend, which is a simple webpack config update. If we later notice issues with this, we can roll-back to use the non-bundled backend in the next community release, which will have the fix above. Note about the webpack config update: as suggested, I have deleted the webpack configs and run "theia build" to have them re-created. Then I re-added the small change we need for the time range context menu. The result is a webpack config that's more aligned with the one Theia generates, for both our example Theia apps. Signed-off-by: Marc Dumais <marc.dumais@ericsson.com>
marcdumais-work
added a commit
to eclipse-cdt-cloud/theia-trace-extension
that referenced
this pull request
Apr 15, 2025
Issue encountered: eclipse-theia/theia#14804 A PR updated "fix-path" and caused the issue: eclipse-theia/theia#14781 A fix was done: eclipse-theia/theia#14812 Side-effect of the fix: eclipse-theia/theia#14804 (comment) Fix to address the side-effect: eclipse-theia/theia#14819 Note: the fix for the side-effect was merged on Theia master, and does not help momentariry on the community release 1.58.x, on which it's not currently planned to back-port this fix: eclipse-theia/theia#14819 (comment) We could contribute a PR to back-port the fix, but I do not think this is super important for us - the Theia Electron app is only an example application and permanently switching to a bundled Electron backend does not seem to have any downside. In consequence, this PR includes using the bundled Electron backend, which is a simple webpack config update. If we later notice issues with this, we can roll-back to use the non-bundled backend in the next community release, which will have the fix above. Note about the webpack config update: as suggested, I have deleted the webpack configs and run "theia build" to have them re-created. Then I re-added the small change we need for the time range context menu. The result is a webpack config that's more aligned with the one Theia generates, for both our example Theia apps. Signed-off-by: Marc Dumais <marc.dumais@ericsson.com>
laemmleint
pushed a commit
to mvtecsoftware/theia
that referenced
this pull request
Aug 18, 2025
…a#14781) cross-env 6.0.6 fixes CVE-2024-21538 (https://security.snyk.io/vuln/SNYK-JS-CROSSSPAWN-8303230). Contributed by STMicroelectronics Signed-off-by: Torbjörn SVENSSON <torbjorn.svensson@foss.st.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cross-env 6.0.6 fixes CVE-2024-21538
(https://security.snyk.io/vuln/SNYK-JS-CROSSSPAWN-8303230).
What it does
Bumps
fix-pathdependency to4.0.0to avoid indirect dependency on vulnerablecross-env@<6.0.6.How to test
I have just bumped the dependency and verified that the electron build starts using details described in the quickstart guide
Follow-ups
Breaking changes
Attribution
Review checklist
Reminder for reviewers
Contributed by STMicroelectronics