-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Run automatic translation on workflow_dispatch
#11526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run automatic translation on workflow_dispatch
#11526
Conversation
@msujew It might not even be possible from forks as the
|
@vince-fugnitto Yeah, I noticed multiple issues already, forks also (unsurprisingly) can't read from our secrets. I'm wondering whether my other idea would be better suited, as it only runs on our repo. The idea was to push to another branch when pushing to Anyway, I'm first looking into whether we can force push from Actions to a protected branch, since that would allow us to perform automatic translations after merging and simply amend it to the squashed commit, thereby preserving the history of why translations were added a bit better. |
@msujew if we wanted, we can add a |
@vince-fugnitto Thanks for the hint! Seems like we also can't push, so automatically creating a PR sounds like the best approach. Works quite well, see msujew#5. Quick question: Do you have an idea whether there's some Eclipse bot/fake email that's covered by the ECA? I'm using my own for now, but that seems a bit weird to me. |
pull_request
workflow_dispatch
10aea73
to
10397ab
Compare
I'm not aware of any bot account :( Is it possible to use the |
@JonasHelming are you aware of any bot account in the foundation (covered by the ECA) that we can use to perform the automatic translation updates? |
Unfortunately, Anyway, I've also updated the |
10397ab
to
fbeec89
Compare
@vince-fugnitto Running Github API requests inside of actions is surprisingly easy, the action now will always commit using the email of the user that triggered the workflow. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 Glad we can figure out a way to make it generic (authorship) and hopefully it addresses the issues we experienced from forks.
@vince-fugnitto Thanks for the quick review. Please let me know if you find any issues once you run this. Maybe we should run this a day before the release to fix any potential issues? |
What it does
Fixes #11525
Instead of running on
push
(which only really works in our own repo), we instead create a workflow, which we'll manually start before creating a new release.How to test
After merging this, a new workflow dispatch should be available, which automatically performs the translation update and creates a new PR based on the results. See msujew#7 for an example of how this would look like.
Review checklist
Reminder for reviewers