revert IPC server change + fix pipe communication on Windows #11561
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @tortmayr |
paul-marechal
commented
Aug 11, 2022
|
@paul-marechal Thanks for following up on that. Using |
msujew
approved these changes
Aug 24, 2022
Node requires 'overlapped' on Windows when creating process pipes for bidirectional communication to work reliably.
5dda706 to
6e0ac93
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Revert #11530
Use
overlappedinstead ofpipewhen opening a process pipe for the bidirectional communication to work properly on all platforms.How to test
File watching should work on every platform: Try renaming files, etc.
Review checklist
Reminder for reviewers