Skip to content

Optionally chain check for logger in test page to reduce probability of failure on load #11069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 25, 2022
Merged

Optionally chain check for logger in test page to reduce probability of failure on load #11069

merged 1 commit into from
Apr 25, 2022

Conversation

colin-grant-work
Copy link
Contributor

@colin-grant-work colin-grant-work commented Apr 22, 2022 •
edited
Loading

What it does

Lately, CI has been failing in the waitFor function when Mocha is loading. This may help.

How to test

Review checklist

Reminder for reviewers

@colin-grant-work colin-grant-work changed the title Optionally chain to reduce probability of failure Optionally chain check for logger in test page to reduce probability of failure on load Apr 22, 2022
@colin-grant-work colin-grant-work added the ci issues related to CI / tests label Apr 22, 2022
@colin-grant-work colin-grant-work marked this pull request as ready for review April 22, 2022 21:09
@colin-grant-work colin-grant-work mentioned this pull request Apr 22, 2022
Closed
7 tasks
vince-fugnitto
vince-fugnitto approved these changes Apr 25, 2022
View reviewed changes
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me, I confirmed by re-running CI 3 times (all three times were successful):

@colin-grant-work colin-grant-work merged commit ef04c37 into eclipse-theia:master Apr 25, 2022
@colin-grant-work colin-grant-work deleted the bugfix/mocha-failing-on-load branch April 25, 2022 14:10
@vince-fugnitto vince-fugnitto added this to the 1.25.0 milestone Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vince-fugnitto vince-fugnitto vince-fugnitto approved these changes

Assignees
No one assigned
Labels
ci issues related to CI / tests
Projects
None yet
Milestone
1.25.0
Development

Successfully merging this pull request may close these issues.
2 participants
@colin-grant-work @vince-fugnitto