Skip to content

Missing menus in CommentSample #12452

@rschnekenbu

Description

@rschnekenbu

Some buttons generated by commands are missing in the comment sample since Theia release 1.28. This can be observed when the menu refactoring #11290 was applied. Before that refactoring, for example on theia 1.27, the buttons were displayed without issues and working.

This was discovered while working on PR #12007 and the issue #12231.
From what I could observe:

  • Before refactoring, the buttons could be seen on the comment sample editor. The process to get the dialog is documented in this CommentThread state PR

theia-1 27-comment

  • After refactoring, e.g. on Theia 1.28+, almost no buttons can be seen using same extension.

theia-master-comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    commentsissues related to comments api and functionalityvscodeissues related to VSCode compatibility

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions