-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Closed
Description
Bug Description:
Steps to Reproduce:
- Open the application in a workspace with symbols (e.g. the Theia repo)
- Open a code file so that there are some symbols to display.
- Use the 'find symbol' shortcut (default:
CtrlCmd+t
) - Observe that an empty quickpick is shown and there is an error in the console to this effect:
Uncaught Error: Failed to execute 'add' on 'DOMTokenList': The token provided ('codicon block codicon-symbol-property') contains HTML space characters, which are not valid in tokens.
Error: Failed to execute 'add' on 'DOMTokenList': The token provided ('codicon block codicon-symbol-property') contains HTML space characters, which are not valid in tokens.
It appears that Monaco is calling classList.add
on the output of this function:
theia/packages/monaco/src/browser/workspace-symbol-command.ts
Lines 154 to 160 in 9332521
protected toCssClassName(symbolKind: SymbolKind, inline?: boolean): string[] | undefined { | |
const kind = SymbolKind[symbolKind]; | |
if (!kind) { | |
return undefined; | |
} | |
return [`codicon ${inline ? 'inline' : 'block'} codicon-symbol-${kind.toLowerCase() || 'property'}`]; | |
} |
And we're treating a sequence of class names as a single string.
Additional Information
- Operating System: MacOS X Sequoia
- Theia Version: dd1bb84
Metadata
Metadata
Assignees
Labels
No labels