Reflection fails due to class file's EnclosingMethod attribute incorrectly pointing to lambda implementation #1072
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
incorrectly pointing to lambda implementation
|
@mpalat, Can you please review this for RC1 please ? TIA |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
According to JVMS 4.7.7, the EnclosingMethod is supposed to point to the closest lexically enclosing method of the class. ECJ incorrectly mentions the lambda implementation method which doesn't meet the criteria.
With this fix, we reach for and encode the right method.
Fixes #975
Author checklist