You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
httpResponse.get() might wait forever if the request takes forever which is possible because no timeout is set and HttpClient blocks forever by default. I didn't find any other uses of HttpRequest.newBuilder() in p2.
I suggest adding a timeout to this and I am willing to contribute that (unless someone else really wants to do that).
Are there any opinions on a good timeout? I would suggest something along the line of 2-5 seconds since the HTTP request taking more time would indicate some sort of issue in which case not accepting the certificate is probably fine.